release geodifflib on shutdown() for macOS - #261
Open
harminius wants to merge 1 commit into
Open
Conversation
wonder-sk
reviewed
Sep 3, 2026
wonder-sk
left a comment
wonder-sk
left a comment
Contributor
There was a problem hiding this comment.
the fix looks sensible....
Comment on lines
+77
to
+78
| lib = getattr(self, "lib", None) | ||
| if lib is not None: |
Contributor
There was a problem hiding this comment.
this is ugly... better to init self.lib = None in the __init__() instead of this
Contributor
|
@harminius let's rebase on top of master to get CI green for windows build of wheels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MerginMaps/qgis-plugin#867 and maybe MerginMaps/qgis-plugin#866
Problem:
shutdown()previously only released the library on Windows; on Linux/macOS it just dropped the Python reference, so ctypes never calleddlclose()and the image stayed mapped. On macOS the old and new copies of the library coexisted in the process resulting in QGIS to crash.Solution:
This makes
pygeodiff.shutdown()actually unload the library on macOS.Limitation:
dlclose()is best-effort - on modern Linux (glibc ≥ 2.34) the library often stays mapped anyway. However, the bug doesn't appear on Linux because it re-dlopen()the lib by its name (SONAME). This means only one copy is ever loaded - unfortunately, the old one.Also added a small guard so a failed load doesn't raise in
__del__.